Add a test to demonstrate issue 13 is not an issue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20 +/- ##
========================================
Coverage 50.88% 50.88%
========================================
Files 16 16
Lines 1476 1476
Branches 313 313
========================================
Hits 751 751
Misses 669 669
Partials 56 56 ☔ View full report in Codecov by Sentry. |
| # Depending on the OS, the error message may vary | ||
| # This was seen on macOS | ||
| # assert stderr == "ls: unrecognized option `--myopt'" + '\n' + \ | ||
| # "usage: ls [-@ABCFGHILOPRSTUWabcdefghiklmnopqrstuvwxy1%,] [--color=when] [-D format] [file ...]" + '\n' |
There was a problem hiding this comment.
I am not sure if this is a planned future test, but if so, the Python string library provides an easy way to define alphabet strings (see the RTDs). Other than that, approved.
HenryRWinterbottom
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
stderrfile is not binary by reading the contents and printing themFixes #13
Type of change
How Has This Been Tested?
Checklist